Поправил валидацию.
This commit is contained in:
psemenkov 2023-05-10 15:03:40 +03:00
parent 3d56c0fc63
commit 05e879112a
6 changed files with 12 additions and 5 deletions

View file

@ -43,6 +43,7 @@ public class ClearingCalendarValidationConfig {
IMDGDistributedNames.Map_Company, IMDGDistributedNames.Map_Company,
Company.class, Company.class,
ValidationError.CompanyNotFound, ValidationError.CompanyNotFound,
false,
company -> WorkflowStatus.Active.equalsByKey(company.getWorkflowStatus()) ? null : ValidationError.CompanyNotActive), company -> WorkflowStatus.Active.equalsByKey(company.getWorkflowStatus()) ? null : ValidationError.CompanyNotActive),
DictionaryPresentRule.instance("dayStatus", DictionaryPresentRule.instance("dayStatus",
ClearingCalendarNewRequest::getDayStatus, ClearingCalendarNewRequest::getDayStatus,
@ -74,6 +75,7 @@ public class ClearingCalendarValidationConfig {
IMDGDistributedNames.Map_Company, IMDGDistributedNames.Map_Company,
Company.class, Company.class,
ValidationError.CompanyNotFound, ValidationError.CompanyNotFound,
false,
company -> WorkflowStatus.Active.equalsByKey(company.getWorkflowStatus()) ? null : ValidationError.CompanyNotActive), company -> WorkflowStatus.Active.equalsByKey(company.getWorkflowStatus()) ? null : ValidationError.CompanyNotActive),
DictionaryPresentRule.instance("dayStatus", DictionaryPresentRule.instance("dayStatus",
ClearingCalendarUpdateRequest::getDayStatus, ClearingCalendarUpdateRequest::getDayStatus,

View file

@ -45,7 +45,9 @@ public class PlannerTemplateValidationConfig {
IMDGDistributedNames.Map_TaskDictionary, IMDGDistributedNames.Map_TaskDictionary,
TaskDictionary.class), TaskDictionary.class),
TimeNotBeforeRule.instance("taskTime", TimeNotBeforeRule.instance("taskTime",
PlannerTemplateNewRequest::getTaskTime), PlannerTemplateNewRequest::getTaskTime,
true,
false),
DictionaryPresentRule.instance("taskStatus", DictionaryPresentRule.instance("taskStatus",
PlannerTemplateNewRequest::getTaskStatus, PlannerTemplateNewRequest::getTaskStatus,
IMDGDistributedNames.Map_TaskStatusDictionary, IMDGDistributedNames.Map_TaskStatusDictionary,
@ -55,6 +57,7 @@ public class PlannerTemplateValidationConfig {
IMDGDistributedNames.Map_Company, IMDGDistributedNames.Map_Company,
Company.class, Company.class,
ValidationError.CompanyNotFound, ValidationError.CompanyNotFound,
false,
company -> WorkflowStatus.Active.equalsByKey(company.getWorkflowStatus()) ? null : ValidationError.CompanyNotActive), company -> WorkflowStatus.Active.equalsByKey(company.getWorkflowStatus()) ? null : ValidationError.CompanyNotActive),
IdPresentRule.instance("securityId", IdPresentRule.instance("securityId",
PlannerTemplateNewRequest::getSecurityId, PlannerTemplateNewRequest::getSecurityId,
@ -90,6 +93,7 @@ public class PlannerTemplateValidationConfig {
false), false),
TimeNotBeforeRule.instance("taskTime", TimeNotBeforeRule.instance("taskTime",
PlannerTemplateUpdateRequest::getTaskTime, PlannerTemplateUpdateRequest::getTaskTime,
false,
false), false),
DictionaryPresentRule.instance("taskStatus", DictionaryPresentRule.instance("taskStatus",
PlannerTemplateUpdateRequest::getTaskStatus, PlannerTemplateUpdateRequest::getTaskStatus,

View file

@ -62,6 +62,7 @@ public class PlannerValidationConfig {
IMDGDistributedNames.Map_Company, IMDGDistributedNames.Map_Company,
Company.class, Company.class,
ValidationError.CompanyNotFound, ValidationError.CompanyNotFound,
false,
company -> WorkflowStatus.Active.equalsByKey(company.getWorkflowStatus()) ? null : ValidationError.CompanyNotActive), company -> WorkflowStatus.Active.equalsByKey(company.getWorkflowStatus()) ? null : ValidationError.CompanyNotActive),
IdPresentRule.instance("securityId", IdPresentRule.instance("securityId",
PlannerNewRequest::getSecurityId, PlannerNewRequest::getSecurityId,

View file

@ -55,6 +55,6 @@ public record EnumPresentRule<R, E extends IEnumKey>(String fieldName,
for (E enumValue : enumValues) { for (E enumValue : enumValues) {
if (enumValue.getKey().equals(enumCode)) return empty(); if (enumValue.getKey().equals(enumCode)) return empty();
} }
return of(ValidationError.WrongEnumValue, fieldName); return of(ValidationError.WrongDictionaryValue, fieldName);
} }
} }

View file

@ -19,7 +19,7 @@ import ru.clearing.platform.dictionary.TaskStatusDictionary;
import ru.spcex.clearing.imdg.IMDGDistributedNames; import ru.spcex.clearing.imdg.IMDGDistributedNames;
import ru.spcex.clearing.scheduler.config.ErrorResolverConfig; import ru.spcex.clearing.scheduler.config.ErrorResolverConfig;
import ru.spcex.clearing.scheduler.config.PlannerQueueConfig; import ru.spcex.clearing.scheduler.config.PlannerQueueConfig;
import ru.spcex.clearing.scheduler.config.SchedulerTestConfig; import ru.spcex.clearing.scheduler.config.SchedulerServiceConfig;
import ru.spcex.clearing.scheduler.config.validation.ClearingCalendarValidationConfig; import ru.spcex.clearing.scheduler.config.validation.ClearingCalendarValidationConfig;
import ru.spcex.clearing.scheduler.config.validation.PlannerTemplateValidationConfig; import ru.spcex.clearing.scheduler.config.validation.PlannerTemplateValidationConfig;
import ru.spcex.clearing.scheduler.config.validation.PlannerValidationConfig; import ru.spcex.clearing.scheduler.config.validation.PlannerValidationConfig;
@ -60,7 +60,7 @@ import static ru.spcex.platform.enumeration.Market.mkrs;
LauncherService.class, LauncherService.class,
ErrorResolverConfig.class, ErrorResolverConfig.class,
PlannerQueueConfig.class, PlannerQueueConfig.class,
SchedulerTestConfig.class, SchedulerServiceConfig.class,
ImdgTestConfig.class, ImdgTestConfig.class,
KafkaTestConfig.class}) KafkaTestConfig.class})
public abstract class AbstractServiceTest { public abstract class AbstractServiceTest {

View file

@ -85,7 +85,7 @@ class EnumPresentRuleTest extends AbstractServiceTest {
setter.accept(record, "BAD_VALUE"); setter.accept(record, "BAD_VALUE");
enumMessages = strictValidator.validateAll(); enumMessages = strictValidator.validateAll();
assertEquals(1, enumMessages.size()); assertEquals(1, enumMessages.size());
assertEquals(ValidationError.WrongEnumValue, enumMessages.iterator().next().getSubject()); assertEquals(ValidationError.WrongDictionaryValue, enumMessages.iterator().next().getSubject());
} }
} }