diff --git a/src/main/java/ru/nbch/credit_tracker/component/comparator/DeletePackageStatusComparator.java b/src/main/java/ru/nbch/credit_tracker/component/comparator/DeletePackageStatusComparator.java index d7bd9a5..b15a3af 100644 --- a/src/main/java/ru/nbch/credit_tracker/component/comparator/DeletePackageStatusComparator.java +++ b/src/main/java/ru/nbch/credit_tracker/component/comparator/DeletePackageStatusComparator.java @@ -1,9 +1,10 @@ package ru.nbch.credit_tracker.component.comparator; +import ru.nbch.credit_tracker.entities.app.UserPackage; +import ru.nbch.credit_tracker.enums.Status; + import java.util.Comparator; import java.util.function.ToIntFunction; -import ru.nbch.credit_tracker.entities.app.UserPackage; -import ru.nbch.credit_tracker.enums.Status; public class DeletePackageStatusComparator { @@ -15,7 +16,7 @@ public class DeletePackageStatusComparator { try { Status status = Status.valueOf(str); return switch (status) { - case ON_MONITORING, PROCESSING_REPEATED, NO_FID -> 1; + case ON_MONITORING -> 1; case DELETED -> 0; default -> -1; }; diff --git a/src/main/java/ru/nbch/credit_tracker/component/comparator/ReportListPackageStatusComparator.java b/src/main/java/ru/nbch/credit_tracker/component/comparator/ReportListPackageStatusComparator.java index cb88f9a..cc1a687 100644 --- a/src/main/java/ru/nbch/credit_tracker/component/comparator/ReportListPackageStatusComparator.java +++ b/src/main/java/ru/nbch/credit_tracker/component/comparator/ReportListPackageStatusComparator.java @@ -1,15 +1,16 @@ package ru.nbch.credit_tracker.component.comparator; +import ru.nbch.credit_tracker.entities.app.UserPackage; +import ru.nbch.credit_tracker.enums.Status; + import java.util.Comparator; import java.util.EnumSet; import java.util.function.ToIntFunction; -import ru.nbch.credit_tracker.entities.app.UserPackage; -import ru.nbch.credit_tracker.enums.Status; public class ReportListPackageStatusComparator { public static final EnumSet reportedStatuses = EnumSet.of( - Status.ON_MONITORING, Status.PROCESSING_REPEATED + Status.ON_MONITORING ); public static Comparator INSTANCE = Comparator @@ -24,7 +25,7 @@ public class ReportListPackageStatusComparator { try { Status status = Status.valueOf(str); return switch (status) { - case ON_MONITORING, PROCESSING_REPEATED -> 1; + case ON_MONITORING -> 1; default -> -1; }; } catch (Throwable e) { diff --git a/src/main/java/ru/nbch/credit_tracker/enums/Status.java b/src/main/java/ru/nbch/credit_tracker/enums/Status.java index c1368bb..04b6b0c 100644 --- a/src/main/java/ru/nbch/credit_tracker/enums/Status.java +++ b/src/main/java/ru/nbch/credit_tracker/enums/Status.java @@ -2,10 +2,8 @@ package ru.nbch.credit_tracker.enums; public enum Status { ON_MONITORING, // пакет стоит на мониторинге в оф. сервисе - NO_FID, REJECTED, // отклонен на стороне НБКИ PROCESSING, // идет поиск телефона и расчет флагов по пакету - PROCESSING_REPEATED, ACCEPTED, DELETED, // пакет удален ERROR; // произошла ошибка при постановке пакета на мониторинг в оф. сервис diff --git a/src/main/java/ru/nbch/credit_tracker/facade/SignalFacade.java b/src/main/java/ru/nbch/credit_tracker/facade/SignalFacade.java index 29df35e..c205ac2 100644 --- a/src/main/java/ru/nbch/credit_tracker/facade/SignalFacade.java +++ b/src/main/java/ru/nbch/credit_tracker/facade/SignalFacade.java @@ -223,8 +223,7 @@ public class SignalFacade { pack.setPackageName(data.getPackageName()); pack.setCreatedAt(data.getCreatedAt() != null ? data.getCreatedAt().toString() : null); Status packageStatus = EnumUtil.getEnum(Status.class, data.getStatus()); - Status statusForClient = packageStatus == Status.ACCEPTED ? Status.PROCESSING : - Arrays.asList(Status.PROCESSING_REPEATED, Status.NO_FID).contains(packageStatus) ? Status.ON_MONITORING : packageStatus; + Status statusForClient = packageStatus == Status.ACCEPTED ? Status.PROCESSING : packageStatus; assert statusForClient != null; pack.setStatus(statusForClient.name()); if (packageStatus == Status.DELETED) { @@ -244,7 +243,7 @@ public class SignalFacade { -> clientExcp(SignalError.ERROR_016, XmlErrorFormat.MonitoringPackageDeleteError, packageName)); Status status = EnumUtil.getEnum(Status.class, packageToDelete.getStatus()); - if (!Arrays.asList(Status.ON_MONITORING, Status.NO_FID).contains(status)) { + if (Status.ON_MONITORING != status) { throw clientExcp(deleteStatusError(status), XmlErrorFormat.MonitoringPackageDeleteError, packageName); } @@ -266,7 +265,6 @@ public class SignalFacade { case PROCESSING, ACCEPTED -> SignalError.ERROR_023; case REJECTED, ERROR -> SignalError.ERROR_024; case DELETED -> SignalError.ERROR_025; - case PROCESSING_REPEATED -> SignalError.ERROR_026; default -> throw new IllegalStateException("Unexpected value: " + status); }; } diff --git a/src/main/java/ru/nbch/credit_tracker/mapper/signal/PackagesRecordsMapper.java b/src/main/java/ru/nbch/credit_tracker/mapper/signal/PackagesRecordsMapper.java index 04dbe2e..fd8a1b7 100644 --- a/src/main/java/ru/nbch/credit_tracker/mapper/signal/PackagesRecordsMapper.java +++ b/src/main/java/ru/nbch/credit_tracker/mapper/signal/PackagesRecordsMapper.java @@ -17,10 +17,6 @@ public interface PackagesRecordsMapper { @Param("limit") int limit, @Param("offset") int offset); - List uniquePackageIdByPhones(@Param("json") String json); - - List uniquePackageIdByInnAndRegNum(@Param("json") String json); - List selectUserPackagePhoneData(@Param("json") String json); List selectUserPackageLegalData(@Param("json") String json); diff --git a/src/main/java/ru/nbch/credit_tracker/mapper/signal/UserPackageMapper.java b/src/main/java/ru/nbch/credit_tracker/mapper/signal/UserPackageMapper.java index 9c783d1..23e27e0 100644 --- a/src/main/java/ru/nbch/credit_tracker/mapper/signal/UserPackageMapper.java +++ b/src/main/java/ru/nbch/credit_tracker/mapper/signal/UserPackageMapper.java @@ -25,14 +25,8 @@ public interface UserPackageMapper { void updatePackageOnMonitoringSuccess(@Param("id") Long id, @Param("monitoringAt") LocalDateTime monitoringAt); - void updateNoFidMonitoring(@Param("id") Long id); - - void setFidChanged(@Param("packageIds") List id); - UserPackage findPackage(@Param("id") Long id); - List findForRepeatedPackages(); - List findUserPackages(@Param("userId") String userId, @Param("statuses") List status); diff --git a/src/main/java/ru/nbch/credit_tracker/service/UserPackageService.java b/src/main/java/ru/nbch/credit_tracker/service/UserPackageService.java index b992d36..a200471 100644 --- a/src/main/java/ru/nbch/credit_tracker/service/UserPackageService.java +++ b/src/main/java/ru/nbch/credit_tracker/service/UserPackageService.java @@ -59,17 +59,13 @@ public class UserPackageService { } public List findActivePackages(String userId) { - return userPackageMapper.findUserPackages(userId.substring(0, 6), Arrays.asList(Status.ON_MONITORING.name(), Status.NO_FID.name())); + return userPackageMapper.findUserPackages(userId.substring(0, 6), Arrays.asList(Status.ON_MONITORING.name())); } public UserPackage findByPackageName(String packageName) { return userPackageMapper.findByPackageName(packageName); } - public void setFidChanged(List id) { - userPackageMapper.setFidChanged(id); - } - public List findAllPackages(String userId) { return userPackageMapper.findAllPackagesByUserId(userId.substring(0, 6)); } diff --git a/src/main/java/ru/nbch/credit_tracker/service/mode/common/StartupRestoreService.java b/src/main/java/ru/nbch/credit_tracker/service/mode/common/StartupRestoreService.java index 33468ea..6d2cec7 100644 --- a/src/main/java/ru/nbch/credit_tracker/service/mode/common/StartupRestoreService.java +++ b/src/main/java/ru/nbch/credit_tracker/service/mode/common/StartupRestoreService.java @@ -100,7 +100,7 @@ public class StartupRestoreService { } private void processingRestore() { - List packages = userPackageMapper.findAllPackagesByStatus(Status.PROCESSING.name(), Status.PROCESSING_REPEATED.name()); + List packages = userPackageMapper.findAllPackagesByStatus(Status.PROCESSING.name()); log.debug("Found {} packages in status PROCESSING", packages.size()); for (UserPackage userPackage : packages) { if (userPackage.getSubjectType() == 1) { diff --git a/src/main/java/ru/nbch/credit_tracker/service/mode/common/UpdatingFidService.java b/src/main/java/ru/nbch/credit_tracker/service/mode/common/UpdatingFidService.java index 69cfb96..e5e4e5d 100644 --- a/src/main/java/ru/nbch/credit_tracker/service/mode/common/UpdatingFidService.java +++ b/src/main/java/ru/nbch/credit_tracker/service/mode/common/UpdatingFidService.java @@ -5,15 +5,12 @@ import org.springframework.scheduling.annotation.EnableScheduling; import org.springframework.scheduling.annotation.Scheduled; import org.springframework.stereotype.Service; import ru.nbch.credit_tracker.config.settings.CreditTrackerSettings; -import ru.nbch.credit_tracker.entities.app.UserPackage; import ru.nbch.credit_tracker.mapper.signal.LegalsMapMapper; -import ru.nbch.credit_tracker.mapper.signal.UserPackageMapper; import ru.nbch.credit_tracker.service.signal.PhonesMapService; import ru.nbch.credit_tracker.service.task.*; import ru.nbch.credit_tracker.service.task.impl.PipelineMode; import ru.nbch.pipeline.engine.core.Pipeline; -import java.util.List; import java.util.concurrent.CompletableFuture; @Slf4j @@ -24,9 +21,6 @@ public class UpdatingFidService { private final LpPipelinePackageFabric lpPipelinePackageFabric; private final NpPipelineRecalcOrchestrator npPipelineRecalcOrchestrator; private final LpPipelineRecalcOrchestrator lpPipelineRecalcOrchestrator; - private final NpPipelinePackageOrchestrator npPipelinePackageOrchestrator; - private final LpPipelinePackageOrchestrator lpPipelinePackageOrchestrator; - private final UserPackageMapper userPackageMapper; private final PhonesMapService phonesMapService; private final LegalsMapMapper legalsMapMapper; @@ -35,18 +29,12 @@ public class UpdatingFidService { LpPipelinePackageFabric lpPipelinePackageFabric, NpPipelineRecalcOrchestrator npPipelineRecalcOrchestrator, LpPipelineRecalcOrchestrator lpPipelineRecalcOrchestrator, - NpPipelinePackageOrchestrator npPipelinePackageOrchestrator, - LpPipelinePackageOrchestrator lpPipelinePackageOrchestrator, - UserPackageMapper userPackageMapper, PhonesMapService phonesMapService, LegalsMapMapper legalsMapMapper) { this.npPipelinePackageFabric = npPipelinePackageFabric; this.lpPipelinePackageFabric = lpPipelinePackageFabric; this.npPipelineRecalcOrchestrator = npPipelineRecalcOrchestrator; this.lpPipelineRecalcOrchestrator = lpPipelineRecalcOrchestrator; - this.npPipelinePackageOrchestrator = npPipelinePackageOrchestrator; - this.lpPipelinePackageOrchestrator = lpPipelinePackageOrchestrator; - this.userPackageMapper = userPackageMapper; this.phonesMapService = phonesMapService; this.legalsMapMapper = legalsMapMapper; } @@ -59,7 +47,7 @@ public class UpdatingFidService { } log.info("Delete unused phones"); phonesMapService.deleteUnusedPhones(); - log.info("Start updating fids and PD"); + log.info("Start updating fids"); try { Pipeline pipeline = npPipelinePackageFabric.buildRecalculationPD(new SetupParam(null, 1, PipelineMode.RECALC_FID)); CompletableFuture future = npPipelineRecalcOrchestrator.startOrReject(pipeline); @@ -70,17 +58,7 @@ public class UpdatingFidService { return; } - List packagesRepeated = userPackageMapper.findForRepeatedPackages(); - packagesRepeated.forEach(userPackage -> { - Long packageId = userPackage.getId(); - SetupParam setupParam = new SetupParam(packageId, 1, PipelineMode.RESEND); - try { - Pipeline makeXmlByCache = npPipelinePackageFabric.build(setupParam); - npPipelinePackageOrchestrator.startOrDelay(makeXmlByCache, packageId); - } catch (Exception e) { - log.error("Failed to build pipeline", e); - } - }); + log.info("Updating NP fids successfully completed."); } finally { log.info("pipeline finished"); pipeline.close(); @@ -98,7 +76,7 @@ public class UpdatingFidService { log.info("The previous task has not yet been completed."); return; } - log.info("Delete unused phones"); + log.info("Delete unused lp maps"); legalsMapMapper.deleteUnusedMaps(); log.info("Start updating fids"); try { @@ -111,17 +89,7 @@ public class UpdatingFidService { return; } - List packagesRepeated = userPackageMapper.findForRepeatedPackages(); - packagesRepeated.forEach(userPackage -> { - Long packageId = userPackage.getId(); - SetupParam setupParam = new SetupParam(packageId, 2, PipelineMode.RESEND); - try { - Pipeline setupPipeline = lpPipelinePackageFabric.build(setupParam); - lpPipelinePackageOrchestrator.startOrDelay(setupPipeline, packageId); - } catch (Exception e) { - log.error("Failed to build pipeline", e); - } - }); + log.info("Updating LP fids successfully completed."); } finally { log.info("pipeline finished"); pipeline.close(); diff --git a/src/main/java/ru/nbch/credit_tracker/service/signal/PackageRecordsService.java b/src/main/java/ru/nbch/credit_tracker/service/signal/PackageRecordsService.java index 05c959f..a9cddee 100644 --- a/src/main/java/ru/nbch/credit_tracker/service/signal/PackageRecordsService.java +++ b/src/main/java/ru/nbch/credit_tracker/service/signal/PackageRecordsService.java @@ -110,34 +110,6 @@ public class PackageRecordsService { } } - public List selectNpUniquePackageIds(List phones) { - try { - String json = entityToJsonMapper.writeValueAsString(phones.stream() - .filter(Objects::nonNull) - .map(phone -> new HashMap() {{ - put("phone", phone); - }}).toList()); - return packagesRecordsMapper.uniquePackageIdByPhones(json); - } catch (JsonProcessingException e) { - throw new RuntimeException(e); - } - } - - public List selectLpUniquePackageIds(List legalsMaps) { - try { - String json = entityToJsonMapper.writeValueAsString(legalsMaps.stream() - .filter(Objects::nonNull) - .map(s -> new HashMap() {{ - put("inn", s.getInn()); - put("reg_num", s.getRegNum()); - }}).toList()); - - return packagesRecordsMapper.uniquePackageIdByInnAndRegNum(json); - } catch (JsonProcessingException e) { - throw new RuntimeException(e); - } - } - public List selectUserPackagePhoneData(Set phones) { try { String json = entityToJsonMapper.writeValueAsString(phones.stream() diff --git a/src/main/java/ru/nbch/credit_tracker/service/task/PackageOrchestrator.java b/src/main/java/ru/nbch/credit_tracker/service/task/PackageOrchestrator.java index 4f24844..57a2998 100644 --- a/src/main/java/ru/nbch/credit_tracker/service/task/PackageOrchestrator.java +++ b/src/main/java/ru/nbch/credit_tracker/service/task/PackageOrchestrator.java @@ -112,8 +112,6 @@ public abstract class PackageOrchestrator { } if (!res.hasFids()) { log.info("No one fid was found by packageId : {}.", packageId); - userPackageMapper.updateNoFidMonitoring(packageId); - return; } PipelineMode mode = ctx.get(PackageVariable.mode); diff --git a/src/main/java/ru/nbch/credit_tracker/service/task/impl/LpFidUpdater.java b/src/main/java/ru/nbch/credit_tracker/service/task/impl/LpFidUpdater.java index 96bcb6e..cf0e9ae 100644 --- a/src/main/java/ru/nbch/credit_tracker/service/task/impl/LpFidUpdater.java +++ b/src/main/java/ru/nbch/credit_tracker/service/task/impl/LpFidUpdater.java @@ -107,12 +107,6 @@ public class LpFidUpdater implements Handler { legalsMapService.updateSearchedAt(notChangingFidLegalMaps); } - if (!changingFids.isEmpty()) { - List packageIds = packageRecordsService.selectLpUniquePackageIds(changingFids); - if (!packageIds.isEmpty()) { - userPackageService.setFidChanged(packageIds); - } - } return new VoidPayload(); } diff --git a/src/main/java/ru/nbch/credit_tracker/service/task/impl/NpFidUpdater.java b/src/main/java/ru/nbch/credit_tracker/service/task/impl/NpFidUpdater.java index 627c24a..fd21f19 100644 --- a/src/main/java/ru/nbch/credit_tracker/service/task/impl/NpFidUpdater.java +++ b/src/main/java/ru/nbch/credit_tracker/service/task/impl/NpFidUpdater.java @@ -8,9 +8,7 @@ import ru.nbch.credit_tracker.model.SubjectProfile; import ru.nbch.credit_tracker.model.impl.PackageVariable; import ru.nbch.credit_tracker.model.impl.SubjectPayload; import ru.nbch.credit_tracker.model.impl.VoidPayload; -import ru.nbch.credit_tracker.service.UserPackageService; import ru.nbch.credit_tracker.service.indic.PersonService; -import ru.nbch.credit_tracker.service.signal.PackageRecordsService; import ru.nbch.credit_tracker.service.signal.PhonesMapService; import ru.nbch.credit_tracker.utils.CTUtil; import ru.nbch.pipeline.engine.core.Handler; @@ -25,20 +23,14 @@ import java.util.stream.Stream; public class NpFidUpdater implements Handler { private final PersonService personService; private final CreditTrackerSettings creditTrackerSettings; - private final PackageRecordsService packageRecordsService; private final PhonesMapService phonesMapService; - private final UserPackageService userPackageService; public NpFidUpdater(PersonService personService, CreditTrackerSettings creditTrackerSettings, - PackageRecordsService packageRecordsService, - PhonesMapService phonesMapService, - UserPackageService userPackageService) { + PhonesMapService phonesMapService) { this.personService = personService; this.creditTrackerSettings = creditTrackerSettings; - this.packageRecordsService = packageRecordsService; this.phonesMapService = phonesMapService; - this.userPackageService = userPackageService; } @Override @@ -79,12 +71,6 @@ public class NpFidUpdater implements Handler { phonesMapService.updateSearchedAt(notChangedPhones); } - if (!changingFids.isEmpty()) { - List packageIds = packageRecordsService.selectNpUniquePackageIds(changingFids); - if (!packageIds.isEmpty()) { - userPackageService.setFidChanged(packageIds); - } - } return new VoidPayload(); } diff --git a/src/main/resources/mybatis/mapper/signal/LegalsMapMapper.xml b/src/main/resources/mybatis/mapper/signal/LegalsMapMapper.xml index 7e4a1af..9a4df02 100644 --- a/src/main/resources/mybatis/mapper/signal/LegalsMapMapper.xml +++ b/src/main/resources/mybatis/mapper/signal/LegalsMapMapper.xml @@ -231,8 +231,7 @@ AND sup.status IN ( 'ON_MONITORING', - 'PROCESSING', - 'PROCESSING_REPEATED' + 'PROCESSING' )) diff --git a/src/main/resources/mybatis/mapper/signal/PackageRecordsMapper.xml b/src/main/resources/mybatis/mapper/signal/PackageRecordsMapper.xml index 36a1591..32c1ef8 100644 --- a/src/main/resources/mybatis/mapper/signal/PackageRecordsMapper.xml +++ b/src/main/resources/mybatis/mapper/signal/PackageRecordsMapper.xml @@ -42,30 +42,6 @@ - - - - @@ -63,8 +62,8 @@ @@ -73,16 +72,6 @@ WHERE id = #{packageId} - - UPDATE signals_user_packages - SET fid_changed = 1, - status = 'PROCESSING_REPEATED' - WHERE id in - - #{packageId} - - - WITH src AS ( SELECT @@ -105,14 +94,7 @@ monitoring_at = #{monitoringAt}, - status = 'ON_MONITORING', - fid_changed = null - WHERE id = #{id} - - - - UPDATE signals_user_packages - SET monitoring_at = created_at, status = 'NO_FID', fid_changed = null + status = 'ON_MONITORING' WHERE id = #{id} @@ -154,21 +136,6 @@ LIMIT 1 - -